Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: simplify C# FFI definitions #2149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RReverser
Copy link
Member

Description of Changes

This is non-functional change, just aligning FFI definitions closer to the language conventions.

C# uses int everywhere for positons and lengths in standard APIs.

Our manual conversions from Rust uint to C# int do the same bitcast anyway, so we might as well change the FFI definitions instead for cleaner code and fewer casts.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Ran dotnet test, waiting for CI for the rest.

This should allow passing even buffers not based on byte arrays. For now this is purely for consistency.
C# uses `int` everywhere for positons and lengths in standard APIs.

Our manual conversions from Rust `uint` to C# `int` do the same bitcast anyway, so we might as well change the FFI definitions instead for cleaner code and fewer casts.
@RReverser RReverser requested a review from kazimuth January 21, 2025 13:43
@bfops bfops added the release-any To be landed in any release window label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants