Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique index + MutTxId::insert not un-deleteting #2156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 21, 2025

Description of Changes

Fixes #2134.
The resolution was a fix to a silly bug where we did not un-delete in case of a unique index.
Also fixes an issue in find_same_row_via_unique_index where it didn't check row equality for the found pointer.

API and ABI breaking changes

None.

Expected complexity level and risk

1

Testing

A regression test is added.

Also ran the repro in the issue:

w1$ spacetime start
w2$ spacetime publish basics -s local -c -y
w2$ spacetime call basics add 1 1 -s local
w2$ spacetime call basics add 1 1 -s local
w1$ ^C
w1$ spacetime start
w2$ spacetime sql basics 'select * from boeuf'
 id | n 
----+---
 1  | 1 

@Centril Centril requested a review from gefjon January 21, 2025 19:54
@Centril Centril force-pushed the centril/fix-2134-update-no-undelete branch from ec114e7 to 8d3067d Compare January 21, 2025 19:55
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the new test. Once you get CI happy, this is good to merge as far as I'm concerned.

@Centril Centril requested a review from gefjon January 21, 2025 20:37
@Centril Centril enabled auto-merge January 21, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update violates set semantics
2 participants