-
Notifications
You must be signed in to change notification settings - Fork 560
Single-threaded subscription evaluation #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshua-spacetime
merged 2 commits into
master
from
joshua/perf/single-threaded-subscription-eval
May 23, 2025
Merged
Single-threaded subscription evaluation #2682
joshua-spacetime
merged 2 commits into
master
from
joshua/perf/single-threaded-subscription-eval
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edd0b35
to
2a553a2
Compare
Base automatically changed from
joshua/perf/no-double-compress-tx-updates
to
master
April 30, 2025 16:48
2350a1f
to
874c4b9
Compare
874c4b9
to
77ff5bc
Compare
8f65cb6
to
ab0b1b5
Compare
ab0b1b5
to
57fa1dd
Compare
57fa1dd
to
07644f1
Compare
gefjon
reviewed
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I don't love having #[allow(unused)]
code committed; it feels a bit too much like commented-out code. I'd rather just remove the thing we don't need any more, and we can add it back in down the line if/when it's useful again.
gefjon
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes rayon from subscription evaluation and replaces its parallel iterators with sequential ones, the purpose of which is to optimize the common case of small updates where multithreading just adds overhead.
API and ABI breaking changes
None
Expected complexity level and risk
1
Just removes rayon and replaces
into_par_iter()
withinto_iter()
.Testing