ci: Update dependencies for the wasm_bindings job
#2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the `Cargo.lock` file of the `wasm_bindings` job reflects the latest available versions. This is what users would end up with on a fresh module, so we want to catch any compile errors arising from a different transitive closure of dependencies than what is in the workspace lock file. Follup-up for: #2714
kim
commented
May 8, 2025
| - name: Build module-test | ||
| run: cargo run -p spacetimedb-cli -- build --project-path modules/module-test | ||
|
|
||
| # TODO(kim): What does this have to do with bindgen? |
There was a problem hiding this comment.
Should we remove this step? Seems redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
Cargo.lockfile of thewasm_bindingsjob reflects thelatest available versions. This is what users would end up with on a
fresh module, so we want to catch any compile errors arising from a
different transitive closure of dependencies than what is in the
workspace lock file.
Follup-up for: #2714
Expected complexity level and risk
1
Testing