Allowed specifying timestamp literals in SQL #2842
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egormanga
force-pushed
the
sql-timestamp-literal
branch
from
4f98460 to
da5c7ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, specifying a timestamp as an ISO-format string in SQL fails with:
Error: Unexpected type: (expected) String != (__timestamp_micros_since_unix_epoch__: I64) (inferred)This PR allows specifying it (along with other, possibly future string literal-based types), as well as fixes the incorrect type order in the above error message (the inferred one should be from SQL, and the expected is the column SATS type).
API and ABI breaking changes
None.
Expected complexity level and risk
1.
Note for reviewers: this should NOT allow anything irrelevant, as
parse()that we call still checks for the types to match.Testing
INSERTing a timestamp column andSELECTingWITHcomparing it.