Update tracy #2856
Draft
Update tracy #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps it should be called `DatabaseLifecycleManager`? This new object is responsible for tracking the lifecycle of a database, and for cleaning up after the database exits. In particular, it: - Unregisters the `Host` from the containing `HostController`. This was previously handled by an ad-hoc on-panic callback closure. - Aborts the database memory usage metrics reporter task. This was previously handled by a `Drop` method on `Host`. - Disconnects all connected WebSocket clients. Previously, this didn't happen at all, as per issue 2630. I've also added some commentary to the WebSocket actor loop. Follow-up commits will add tests once I've consulted with the team about how best to test this change.
…-disconnect-clients This was a pretty painful merge commit. I had to add `_catch_panic` variants of `run` and `asyncify`, and resolve a lot of conflicts. Conflicts: crates/client-api/src/routes/subscribe.rs crates/core/src/host/host_controller.rs crates/core/src/host/module_host.rs
A linux build system only exists for newer versions of the tracy application, and that claims the protocol is incompatible with `tracing-tracy` 0.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
Expected complexity level and risk
Testing