-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems hard to argue with and it passes CI!
Closed
bfops
added a commit
that referenced
this pull request
Aug 29, 2024
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
lcodes
pushed a commit
that referenced
this pull request
Sep 29, 2024
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
3 tasks
bfops
added a commit
that referenced
this pull request
Oct 4, 2024
## Description of Changes Release these changes: ``` 2783385 0.12.0 DLLs (again) (#161) 7046408 Update to tests/examples follow codegen changes (#160) a7c720f Use SpacetimeDBNetworkManager everywhere (#157) 8916c18 Upgrade SDK Version to 0.12 (#156) b79d90c Fix UnityNetworkManager (#141) cff42fb Accept multiple queries in Subscribe (#153) 8f9614d Update DLLs for 0.12.0 (#152) 62a092e Jeremie/remove break (#154) ce76890 Try to catch flaky bugs (#150) 8ce9b7b Remove obsolete tools folder (#149) 19e8979 Fix `gen-client-api` scripts for new CLI API (#151) f04e2fd Add script to generate `nuget.config` (#115) f9c71c0 Don't actually try to connect to network in tests (#144) 00d2741 Reduce public API surface further (#145) 2bed3c3 Tighten package sources in C# smoketests (#133) 63e6f79 Fix UnityDebugLogger implementation (#143) 8df6d15 Implement websocket changes atop C# sdk changes (#136) 95b9d17 Hide more APIs (#140) 2aae961 Add DbConnection argument to OnConnect (#138) 0981b89 Merge table cache into table handle (#139) f8ddab7 Subscription API (#137) 7bef448 c# client SDK (DbConnection + SDK Callbacks) (#131) 65c97ad Logging API (#132) 7941798 Copy files from old repo (#127) 9904a02 Nix `Primitives.cs` - types now defined in main repo (#120) 5e612f3 Update DEVELOP.md to reflect new codegen (#119) ae7c531 Restore `dotnet pack` functionality (#118) 9481380 Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 (#116) ``` ## API Almost certainly a breaking change ## Requires SpacetimeDB PRs Requires version 0.12.0 in SpacetimeDB --------- Co-authored-by: Mazdak Farrokhzad <[email protected]> Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: Jeremie Pelletier <[email protected]> Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: SteveGibson <[email protected]> Co-authored-by: Steve Boytsun <[email protected]> Co-authored-by: John Detter <[email protected]> Co-authored-by: John Detter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559.
API
Not breaking.
Requires SpacetimeDB PRs
AlgebraicType
, getting rid ofBuiltinType
SpacetimeDB#1559