Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription API #137

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Subscription API #137

merged 5 commits into from
Oct 1, 2024

Conversation

RReverser
Copy link
Contributor

@RReverser RReverser commented Sep 30, 2024

Description of Changes

Implements the subscription builder (at least, the parts that are possible to implement).

API

  • This is an API breaking change to the SDK

If the API is breaking, please state below what will break

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

@RReverser RReverser requested a review from lcodes September 30, 2024 21:15
@RReverser RReverser marked this pull request as draft September 30, 2024 21:23
Base automatically changed from jeremie/client-sdk-api to staging October 1, 2024 01:06
@RReverser RReverser force-pushed the ingvar/client-sdk-api branch from 082cac2 to 52c268d Compare October 1, 2024 13:30
@RReverser RReverser requested a review from SteveBoytsun October 1, 2024 13:30
@RReverser RReverser marked this pull request as ready for review October 1, 2024 13:31
@@ -158,5 +158,7 @@ protected override bool Dispatch(IEventContext context, Reducer reducer) {
_ => throw new ArgumentOutOfRangeException("Reducer", $"Unknown reducer {reducer}")
};
}

public SubscriptionBuilder<EventContext> SubscriptionBuilder() => new(this);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done this manually for now, it will need codegen changes once the client codegen part of clockworklabs/SpacetimeDB#1707 lands.

Copy link
Collaborator

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on call. This LGTM

@RReverser RReverser enabled auto-merge (squash) October 1, 2024 16:17
@RReverser RReverser merged commit f8ddab7 into staging Oct 1, 2024
2 checks passed
@RReverser RReverser deleted the ingvar/client-sdk-api branch October 1, 2024 16:17
bfops added a commit that referenced this pull request Oct 4, 2024
## Description of Changes
Release these changes:
```
2783385 0.12.0 DLLs (again) (#161)
7046408 Update to tests/examples follow codegen changes (#160)
a7c720f Use SpacetimeDBNetworkManager everywhere (#157)
8916c18 Upgrade SDK Version to 0.12 (#156)
b79d90c Fix UnityNetworkManager (#141)
cff42fb Accept multiple queries in Subscribe (#153)
8f9614d Update DLLs for 0.12.0 (#152)
62a092e Jeremie/remove break (#154)
ce76890 Try to catch flaky bugs (#150)
8ce9b7b Remove obsolete tools folder (#149)
19e8979 Fix `gen-client-api` scripts for new CLI API (#151)
f04e2fd Add script to generate `nuget.config` (#115)
f9c71c0 Don't actually try to connect to network in tests (#144)
00d2741 Reduce public API surface further (#145)
2bed3c3 Tighten package sources in C# smoketests (#133)
63e6f79 Fix UnityDebugLogger implementation (#143)
8df6d15 Implement websocket changes atop C# sdk changes (#136)
95b9d17 Hide more APIs (#140)
2aae961 Add DbConnection argument to OnConnect (#138)
0981b89 Merge table cache into table handle (#139)
f8ddab7 Subscription API (#137)
7bef448 c# client SDK (DbConnection + SDK Callbacks) (#131)
65c97ad Logging API (#132)
7941798 Copy files from old repo (#127)
9904a02 Nix `Primitives.cs` - types now defined in main repo (#120)
5e612f3 Update DEVELOP.md to reflect new codegen (#119)
ae7c531 Restore `dotnet pack` functionality (#118)
9481380 Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 (#116)
```
## API
Almost certainly a breaking change


## Requires SpacetimeDB PRs
Requires version 0.12.0 in SpacetimeDB

---------

Co-authored-by: Mazdak Farrokhzad <[email protected]>
Co-authored-by: Zeke Foppa <[email protected]>
Co-authored-by: Jeremie Pelletier <[email protected]>
Co-authored-by: Ingvar Stepanyan <[email protected]>
Co-authored-by: SteveGibson <[email protected]>
Co-authored-by: Steve Boytsun <[email protected]>
Co-authored-by: John Detter <[email protected]>
Co-authored-by: John Detter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants