Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion to SpacetimeDB#1812 (light tx, C#) #170

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 15, 2024

Description of Changes

Adds C# sdk support for clockworklabs/SpacetimeDB#1812.

Requires SpacetimeDB PRs

Testsuite

SpacetimeDB branch name: centril/websocket-light

@Centril Centril force-pushed the centril/websocket-light branch from 53d5c75 to 3bad3a8 Compare October 15, 2024 15:14
Base automatically changed from centril/websocket-gzip to staging October 15, 2024 19:47
@Centril Centril force-pushed the centril/websocket-light branch 7 times, most recently from 3798ed7 to 2fbc5bd Compare October 15, 2024 21:56
@Centril Centril force-pushed the centril/websocket-light branch from 2fbc5bd to c15951a Compare October 17, 2024 13:57
@Centril Centril changed the base branch from staging to centril/websocket-gzip3 October 17, 2024 13:58
@Centril Centril requested a review from jdetter October 22, 2024 18:00
@@ -65,6 +66,12 @@ public DbConnectionBuilder<DbConnection, Reducer> WithCompression(Compression co
return this;
}

public DbConnectionBuilder<DbConnection, Reducer> WithLightMode(bool light)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question why this needs to take a bool, tbh, since false is the default and so the only reason to call this is to assign true, but I also don't care.

@cloutiertyler
Copy link
Collaborator

As far as I can determine these are missing meta files. I added the missing meta files

@Centril Centril force-pushed the centril/websocket-gzip3 branch from d43ae41 to 0f7ca15 Compare October 30, 2024 12:07
@Centril Centril force-pushed the centril/websocket-light branch from 1e81268 to b83cc54 Compare October 30, 2024 12:20
@Centril Centril changed the title Companion to SpacetimeDB#1812 Companion to SpacetimeDB#1812 (light tx) Oct 30, 2024
@Centril Centril force-pushed the centril/websocket-gzip3 branch from 0f7ca15 to e4911fe Compare October 30, 2024 13:26
@Centril Centril force-pushed the centril/websocket-light branch from b83cc54 to b538f7c Compare October 30, 2024 13:27
@lcodes lcodes force-pushed the centril/websocket-light branch from b538f7c to 8a65659 Compare October 30, 2024 20:40
@Centril Centril force-pushed the centril/websocket-gzip3 branch from 67ab96f to bffa8cf Compare October 31, 2024 17:45
@Centril Centril force-pushed the centril/websocket-light branch from 8a65659 to 3572fd3 Compare October 31, 2024 17:48
Base automatically changed from centril/websocket-gzip3 to staging October 31, 2024 18:08
support TransactionUpdateLight
support SetReducerFlags
@Centril Centril force-pushed the centril/websocket-light branch from 3572fd3 to befe0d1 Compare October 31, 2024 18:10
@Centril Centril changed the title Companion to SpacetimeDB#1812 (light tx) Companion to SpacetimeDB#1812 (light tx, C#) Nov 4, 2024
@Centril Centril merged commit a395fd3 into staging Nov 4, 2024
6 checks passed
@Centril Centril deleted the centril/websocket-light branch November 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants