Unity Testsuite #176
Closed
Unity Testsuite #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/unity-testsuite
branch
from
a41ecde to
ef84d6b
Compare
3 tasks
jdetter
force-pushed
the
jdetter/unity-testsuite
branch
from
5d47384 to
25a8c1b
Compare
jdetter
changed the base branch from
staging
to
jdetter/unity-testsuite-import
jdetter
force-pushed
the
jdetter/unity-testsuite
branch
from
746d728 to
547187e
Compare
|
Ingvar suggested we add a check which verifies that the client bindings on the branch being tested are up-to-date, I agree with this and I've added the check. |
|
@jdetter I am going to approve this, however, I am also going to schedule a meeting with @RReverser @SteveBoytsun @lcodes @Centril with the purpose of having you explain in person how it works, so that we can hand it off to others with them being able to understand the tricky problems of setting this up. |
cloutiertyler
changed the base branch from
jdetter/unity-testsuite-import
to
staging
|
Should merge after this: #177 |
Centril
changed the base branch from
staging
to
jdetter/unity-testsuite-import
added 3 commits
October 30, 2024 13:04
the future Add testing section to PR description (#164) v Below is a render of what the new PR description looks like *Describe what has been changed, any new features or bug fixes* - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* *List any PRs here that are required for this SDK change to work* *Write instructions for a test that you performed for this PR* - [ ] Describe a test for this PR that you have completed Working on a more ergonomic CI workflow Workflow runs on staging Small bug fix Test again speedup Use public bindings Use serial instead of license Updated default branch to be master Disable all but one test because we don't support reconnections right now Small update Fixes Testsuite uses local reference to SDK Added comma debugging One more debug Small changes small sed fix Small fix - newline character was messing up branch name Added debug Updated how branch name is populated We'll give this a try to make the C# SDK happy C# tests building! Updated README Small fix Move unity-tests to unity-tests~ Use relative path reference Use relative path reference Small update to the workflow Updated README for new functionality
Centril
force-pushed
the
jdetter/unity-testsuite
branch
from
a39e0a3 to
87fa4fc
Compare
|
Rebased this atop of a rebased Also changed the test-against stdb commit to |
jdetter
commented
Oct 30, 2024
| ## Testsuite | ||
| *If you would like to run against a specific SpacetimeDB branch in the testsuite, specify that here. This can be a branch name or a link to a PR.* | ||
|
|
||
| SpacetimeDB branch name: master |
There was a problem hiding this comment.
let's call this a ref instead
jdetter
commented
Oct 30, 2024
| Library-SpacetimeDBUnityTestsuite- | ||
| Library- | ||
|
|
||
| - name: Set up Unity |
There was a problem hiding this comment.
add this link: https://game.ci/docs/github/getting-started/
Centril
force-pushed
the
jdetter/unity-testsuite
branch
from
b4e05e8 to
fc1b649
Compare
lcodes
force-pushed
the
jdetter/unity-testsuite-import
branch
from
e174841 to
3048408
Compare
3 tasks
Centril
pushed a commit
that referenced
this pull request
Oct 31, 2024
**Please do not rebase this PR** ## Description of Changes *Describe what has been changed, any new features or bug fixes* This is very similar to #176 except it imports the circle game as a submodule instead of copying the code over into this repo. This is the SpacetimeDBCircleGame PR that we're dependent on right now: clockworklabs/SpacetimeDBCircleGame#3 - This PR introduces a testsuite which runs in Unity. Right now it just spawns in a circle, eats some food and verifies the decay logic is working correctly. I've also written some reconnection tests but they don't work because reconnections are currently broken. There are also one-off tests but those don't work either because they also require reconnections to be working. Update: reconnections have been fixed via #168. I've used the built-in unity testsuite framework to achieve this, along with the UnityCI tool from GameCI. The documentation for this docker container can be found here: https://game.ci/docs/github/getting-started/ ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* Not breaking ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* None ## Testsuite SpacetimeDB branch name: 0935b7346b825b8cbb9f36d9ed256136b73b5f0b ## Testing *Write instructions for a test that you performed for this PR* - [x] The testsuite is passing: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/actions/runs/11604456943/job/32313229775 You can follow test instructions here to double check my work: clockworklabs/SpacetimeDBCircleGame#3 ## Follow-up Actions - [ ] Rebase the reconnection logic PR onto this PR and re-enable the reconnection tests --------- Co-authored-by: John Detter <[email protected]>
|
closed in favor of #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Describe what has been changed, any new features or bug fixes
Update: reconnections have been fixed via #168 . In that PR I have enabled all tests!
I've used the built-in unity testsuite framework to achieve this, along with the UnityCI tool from GameCI. The documentation for this docker container can be found here: https://game.ci/docs/github/getting-started/
Rendered README for our testsuite which includes local testing instructions: https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk/blob/jdetter/unity-testsuite/unity-tests~/README.md
API
If the API is breaking, please state below what will break
Not breaking
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work
None
Testsuite
SpacetimeDB branch name: 0935b7346b825b8cbb9f36d9ed256136b73b5f0b
Testing
Write instructions for a test that you performed for this PR