-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the quickstart module #185
Conversation
Do you know why this change is required? Like does this work around an underlying bug that we should be fixing in the SDK, or is this the expected usage now? (And should we be printing a message if users do trigger this by... calling |
It's the 0.12 usage until the 1.0 subscriptions are implemented. But since I keep getting burned by it when testing after switching branches, might as well solve it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. For context this is currently overwriting the subscription. This will eventually be allowable as multiple subscriptions, but it is not for now.
@lcodes When I build the module for the quickstart I get some errors, I believe it's because we haven't changed the Cargo.toml to point to 0.12, did you run into this when you tested your PR?
|
@@ -62,6 +62,18 @@ dependencies = [ | |||
"generic-array", | |||
] | |||
|
|||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we mean to commit this?
d28009f
to
7e2e8bb
Compare
Fix the quickstart client program, also removes the rust server program (it lives in the stdb main repo under modules/quickstart-chat) Second subscription resets the first one without the fix SpacetimeDB branch name: master
Description of Changes
Fix the quickstart client program
Testing
Second subscription resets the first one without the fix
Testsuite
SpacetimeDB branch name: master