-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.0.0-rc1-hotfix1 #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description of Changes Required to make "SDK Tests" pass in clockworklabs/SpacetimeDB#1559. ## API Not breaking. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1559 --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes Single-line change so that `dotnet pack` stops complaining that nothing was generated. Per @RReverser this brings this package more in line with our other C# packages. ## API Nah nothing breaking. ## Requires SpacetimeDB PRs Nope --------- Co-authored-by: Zeke Foppa <[email protected]>
Also ran it again, committing a few generation changes too :)
## Description of Changes These types have been moved to the main repo, where they are used by bindings-csharp as well. ## Requires SpacetimeDB PRs - clockworklabs/SpacetimeDB#1477 --------- Co-authored-by: Ingvar Stepanyan <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes For some reason, this repo was not quite properly synced up with the state of https://github.com/clockworklabs/com.clockworklabs.spacetimedbsdk-archive after #117. It's unclear to me how this happened, since the current state seems to be compatible with 0.11, but the [0.11 release commit/PR](clockworklabs/com.clockworklabs.spacetimedbsdk-archive@382cce0) also bumped the `package.json` version, which didn't happen in this repo. I re-copied files over. Fortunately, the only real changes were to `package.json` and `README.md`. ## API No breaking changes. ## Requires SpacetimeDB PRs None Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes *Describe what has been changed, any new features or bug fixes* Changed logging based on [this proposal](clockworklabs/SpacetimeDBPrivate#981) ## API - [x] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* Logging interface is different now. `Logger` has been renamed to `Log`, and its methods have been renamed as well (ex. `Logger.LogError` is now `Log.Error`) ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: Jeremie Pelletier <[email protected]> Co-authored-by: Steve Boytsun <[email protected]> Co-authored-by: Ingvar Stepanyan <[email protected]>
Implementation of the db connection proposal for C# --------- Co-authored-by: Ingvar Stepanyan <[email protected]>
## Description of Changes Implements the subscription builder (at least, the parts that are possible to implement). ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Merges cache into the table handle as suggested on the original PR + hides most table methods that shouldn't be part of the stable API. Few remaining methods will need a codegen change to be available only to subclasses, so for now that's out of scope. Same for merging ClientCache into RemoteTables - we shouldn't need a separate collection, and instead could autogenerate a switch expression over table name. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Removing unstable APIs that are not used by BitCraft; marking others with [Obsolete] and renaming few others to match the proposal. One exception is InternalCallReducer - it would need some further changes to codegen; marking it as Obsolete right now would cause all generated clients to show noisy warnings. ## API - [x] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Requires SpacetimeDB PRs This is the C# side of clockworklabs/SpacetimeDB#1761.
## Description of Changes Without explicit reference these result in > error CS0119: 'UnityDebugLogger.Debug(string)' is a method, which is not valid in the given context ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Same as clockworklabs/SpacetimeDB#1735 but for this repo. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [x] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Adds a utility script to generate `nuget.config` given a path to the `SpacetimeDB` repo. ## API No ## Requires SpacetimeDB PRs None ## Testing - [x] CI - [x] Ran locally --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes The CLI arg changes in clockworklabs/SpacetimeDB#1741 broke these scripts. This PR incorporates the param renames. ## API No changes to how things are used. ## Requires SpacetimeDB PRs I guess clockworklabs/SpacetimeDB#1741 --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes Not sure when or how this was added (it's not on master), but this folder shouldn't be here - we have `tools~` instead. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes We have some flaky bug where Events are getting modified while we're already iterating over them in the snapshot. I think this might've been fixed by #144, but add extra checks just in case so that the exception is thrown in a concrete event that causes it, and not inside snapshot serialization. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Updated the DLLs for 0.12.0 from the PR: ``` commit 0a7512d2a8db0dcff05aaee92f260e53d71cdc80 (HEAD -> release/v0.12.0-beta, origin/release/v0.12.0-beta) Author: Zeke Foppa <[email protected]> Date: Thu Oct 3 09:35:27 2024 -0700 [release/v0.12.0-beta]: Manually apply open PR #1707: c# client generate ``` ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: Zeke Foppa <[email protected]> Co-authored-by: John Detter <[email protected]>
## Description of Changes Turns out, we're not ready for single Subscribe per query, so bringing back this ability. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* Co-authored-by: John Detter <[email protected]>
This got broken when we switched to a new DbConnection API. Keep track of all the active connections and update/destroy them from a singleton game object. Fixes #134. Marked as a draft for now, because it's untested and because we're not yet sure that singleton for all connections as requested is the right approach. ## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: John Detter <[email protected]> Co-authored-by: John Detter <[email protected]>
## Description of Changes *Describe what has been changed, any new features or bug fixes* - Upgrade version to 0.12. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* Co-authored-by: John Detter <[email protected]>
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* Co-authored-by: John Detter <[email protected]>
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work*
## Description of Changes Update with the latest DLLs from the current 0.12.0 branch. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: Zeke Foppa <[email protected]>
## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: John Detter <[email protected]>
## Description of Changes Companion to clockworklabs/SpacetimeDB#1802. ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#1802
## Description of Changes *Describe what has been changed, any new features or bug fixes* - switched our "already connected" logic to using a reference to a `MonoBehaviour` instead of just a bool. `MonoBehaviour`s are typically destroyed when a scene reload happens and in this case we'll want to allow developers to spawn a new `SpacetimeDBNetworkManager` if the previous one has been destroyed. ## API This is *not* an API break. - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* - clockworklabs/SpacetimeDB#1869 ## Testsuite SpacetimeDB branch name: master ## Testing *Write instructions for a test that you performed for this PR* - [x] I have added in several new tests here, one of which is a reconnection test. Also, the reason why we couldn't have more than 1 test before this is that it was required for reconnections to be working in order to have multiple tests running in the testsuite. Now that we have fixed reconnections I have enabled all of the tests. Testsuite passes ![image](https://github.com/user-attachments/assets/09ef5835-f2c7-41f1-af6b-e612ac5e0497) --------- Co-authored-by: John Detter <[email protected]> Co-authored-by: Mazdak Farrokhzad <[email protected]> Co-authored-by: Jeremie Pelletier <[email protected]> Co-authored-by: Zeke Foppa <[email protected]>
Fix the quickstart client program, also removes the rust server program (it lives in the stdb main repo under modules/quickstart-chat) Second subscription resets the first one without the fix SpacetimeDB branch name: master
## Description of Changes Just bump `package.json` to `1.0.0-rc1` instead of `1.0.0`. ## API No breaking changes ## Requires SpacetimeDB PRs None ## Testing Co-authored-by: Zeke Foppa <[email protected]>
bfops
changed the title
Release/v1.0.0 rc1 C# endianness hotfix
Release/v1.0.0 rc1 hotfix
Nov 12, 2024
cloutiertyler
approved these changes
Nov 12, 2024
Centril
pushed a commit
that referenced
this pull request
Nov 19, 2024
## Description of Changes Cherrypicking the changes from #190, which were merged directly to `master` (by me, without thinking it through). ## API Fixes API breakage related to endianness. ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#1964 ## Testsuite SpacetimeDB branch name: master ## Testing CI only. These changes have already been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We have included the packages corresponding to clockworklabs/SpacetimeDB#1964.
API
Fixes API breakage related to endianness.
Requires SpacetimeDB PRs
SpacetimeDB branch name: release/v1.0.0-rc1-hotfix2
Testsuite
SpacetimeDB branch name: release/v1.0.0-rc1-hotfix2
Testing
CI only