Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CI #88

Merged
merged 3 commits into from
May 13, 2024
Merged

Add basic CI #88

merged 3 commits into from
May 13, 2024

Conversation

RReverser
Copy link
Member

Description of Changes

As found out the hard way in #87, currently there are no CI checks to validate that code is even syntactically valid before merging.

This adds a basic build step that verifies that client example (and, by extension, the library itself as it relies on it) builds successfully.

API

  • This is an API breaking change to the SDK

If the API is breaking, please state below what will break

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

@RReverser RReverser requested review from kazimuth and jdetter May 11, 2024 20:42
RReverser added 3 commits May 13, 2024 16:46
As found out the hard way in #87, currently there are no CI checks to validate that code is even syntactically valid before merging.

This adds a basic build step that verifies that client example (and, by extension, the library itself as it relies on it) builds successfully.
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it, thanks Ingvar 👍

@RReverser RReverser merged commit e79dcea into master May 13, 2024
2 checks passed
@RReverser RReverser deleted the ci-support branch May 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants