Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.9.2 #95

Merged
merged 1 commit into from
May 28, 2024
Merged

Bump version to 0.9.2 #95

merged 1 commit into from
May 28, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented May 23, 2024

Description of Changes

Just bumps the version number. Since 0.9.1 has been released, we are now on 0.9.2+!

API

  • This is an API breaking change to the SDK

If the API is breaking, please state below what will break

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

@bfops bfops requested a review from RReverser May 23, 2024 22:00
@RReverser
Copy link
Member

Did we land any new changes for that one? If not, I'm pretty sure that back when we talked about it, Tyler said we don't need to keep patch versions the same across SDKs because each SDK might have its own changes / development not related to SpacetimeDB itself.

So we set 0.x to match across SDKs but last patch component is for each SDKs own iteration.

@bfops bfops marked this pull request as ready for review May 24, 2024 15:06
@RReverser
Copy link
Member

As discussed in chat, let's either bump one up (to 0.9.1) or just not bump at all since master already has a tag so no new changes here.

@kurtismullins
Copy link
Contributor

As discussed in chat, let's either bump one up (to 0.9.1) or just not bump at all since master already has a tag so no new changes here.

I think that moving forward, this is a good idea. Since @bfops already had the versions set to v0.9.2-beta, I decided to leave it there for this release. I will not merge this Pull Request so that master is unaffected. Just note that the latest version pushed to nuget is v0.9.2.

As mentioned in Discord -- we did skip v0.9.1. Maybe someone can just push a release there so its not missing? It can be the same as v0.9.0. I don't think its super important but does look weird, historically speaking.

@RReverser
Copy link
Member

I will not merge this Pull Request so that master is unaffected. Just note that the latest version pushed to nuget is v0.9.2.

Well if it's published to nuget, then let's merge it. Github repo should reflect nuget state, or the next person trying to bump version is gonna be even more confused.

@kurtismullins kurtismullins merged commit c930fb7 into master May 28, 2024
2 checks passed
@kurtismullins kurtismullins deleted the bfops/bump-version branch May 28, 2024 19:48
@RReverser
Copy link
Member

In fact, we should have merged it before I merged 025a84c as the history looks weird now (that commit is not part of 0.9.2, even though it precedes it). Oh well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants