Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion to SpacetimeDB#1812 (light tx, ts) #110

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 16, 2024

Description of Changes

Adds TS sdk support for clockworklabs/SpacetimeDB#1812.

Requires SpacetimeDB PRs

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 681cb76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clockworklabs/spacetimedb-sdk Minor
@clockworklabs/test-app Patch
client-vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@110

commit: 681cb76

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@110

commit: c0f0545

@Centril Centril force-pushed the centril/websocket-light branch from c0f0545 to 608a522 Compare October 16, 2024 14:06
@Centril Centril requested a review from PuruVJ October 22, 2024 18:09
Base automatically changed from gzip to main October 23, 2024 16:57
@PuruVJ
Copy link
Contributor

PuruVJ commented Oct 23, 2024

Could you resolve the conflicts? Also, please add changesets. Run pnpm changeset at the root of project, select the SDK at the Major checkpoint, and describe ur changes in one line

@Centril Centril force-pushed the centril/websocket-light branch from 038059b to 751d741 Compare October 23, 2024 17:50
@Centril
Copy link
Contributor Author

Centril commented Oct 23, 2024

@PuruVJ I've rebased. Can you run the changeset stuff please? You can paste this line:

Support light tx updates via builder.with_light_mode(_) and the call flag NoSuccessNotify.

@Centril Centril changed the title Companion to SpacetimeDB#1812 Companion to SpacetimeDB#1812 (light tx, ts) Oct 31, 2024
@bfops bfops merged commit a501f5c into main Nov 6, 2024
6 checks passed
@bfops bfops deleted the centril/websocket-light branch November 6, 2024 20:34
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants