Modernize #52
Merged
Modernize #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Push * Push * Run prettier * Prettier stuff
* Push * jest
* Monorepo * Readme * Move tsconfig * Fix test
* Quickstart * test app too * Run pnpm * Remove eslint files * Format
* Push * Undo min change
* Use undici, remove other unneeded dependencies * pnpm install * Bundle everything * Move everything to devDependency * headers object * Bump version to 0.11.0 * Push * Hmm not working still * Add undici to peerDependencies * Measure size * Push * Fix formatting * Working on node!! --------- Co-authored-by: Zeke Foppa <github.com/bfops> Co-authored-by: Zeke Foppa <[email protected]>
* Push * Run pnpm install
* Add pkg.pr.new * Fix directory
|
|
commit: |
* Push * Push * pnpm install * Any update
* Push * Forgot to rename * We only care about Lint at commit level
* Push * Webpackignore
* Push * Remove webpackIgnore
|
Converting to draft as #80 needs to be done in this |
* Push * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
packages/sdkindex.jsfile, and ship it to user. Which means we control the entire code, and the user won't end up with a different patch ofbrotli, orbufferthan ours which could cause issues. Also means the user's own download size is now severely reduced, no need to download all the deps and their README's licenses, package.json and a lot of unnecessary stuff.tsup. All the code is bundled up into one index.js file that is shipped, gone are the days of us shipping our entire filesystem structure with 2 pairs of files(.js + d.ts). tsup also generates a single d.ts file containing all the typings. UPDATE: We do conditional builds now, separate forbrowser. See modernize: Conditional browser build #79isomorphic-wstoundici, which is the internal implementation of native NodeJS Websockets. This is to make our library work the same everywhere, whether it is browsers, Node, Bun, Deno, Cloudflare workers or any other environment that could potentially be a usable runtime.undici, which is for NodeJS 18(and 20, altho that might change) is required, and I'll add that in a separate documentation PR.pnpm run changesetcommand to add a Changelog-message for the PR, and then merging the PR will open a new PR "Version packages", by Changeset Bot. Only on approving and merging that PR will it publish to NPMPRs