Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactoring to use consistent names for :group-id/:artifact-id #676

Closed
wants to merge 7 commits into from

Conversation

firthh
Copy link
Contributor

@firthh firthh commented Dec 29, 2017

Addressing issue #525
It's still work in progress but I thought I'd open an issue so that there would be more visibility into some of the changes as there are going to be a lot of them.

@tobias
Copy link
Member

tobias commented Jan 6, 2018

Thanks for tackling this. You are a saint for taking it on. I made some changes to the jar page (279c583) that may impact your work, sorry if that makes for painful merging.

@firthh
Copy link
Contributor Author

firthh commented Jan 8, 2018

@tobias Thankfully I've been focusing on :group-id so far so there were no conflicts rebasing.

Considering how many changes there are already so far I think it would be nice break this down into smaller chunks so it can get merged in sooner. I'm open to suggestions as to what might be a nice way to break this down?

@tobias
Copy link
Member

tobias commented Jun 13, 2020

@firthh apologies for letting this linger for so long. Is this something you would like to pick back up? If so, I'm happy to help with it.

@tobias tobias closed this Jun 15, 2020
@tobias
Copy link
Member

tobias commented Jun 15, 2020

This was closed when I renamed the master branch to main. Feel free to restart the discussion here if you want to continue working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants