Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haystack to Orchard #919

Merged
merged 4 commits into from
Mar 14, 2025
Merged

Haystack to Orchard #919

merged 4 commits into from
Mar 14, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Mar 11, 2025

Multiple things going on in this PR:

  1. Remove analyze-stacktrace ops (the ones that took an exception printed as string, parsed it, and returned as an exception object that can be presented via *cider-error*). The idea is that More permissive orchard.info parsing of stacktrace output orchard#320 will cover the usecases where user wants to jump to source location from a printed stacktrace, and that is more discoverable than a separate quite obscure command.
  2. Replace the usage of haystack.analyzer with orchard.stacktrace. The latter is almost the same as the former, but with improvements and optimizations. See [stacktrace] Repatriate stacktrace analyzer from Haystack orchard#322.
  3. I rewrote a few test namespaces along the way to use matcher-combinators to reduce noise and improve error reporting.

I plan to let it hang here for some time while I dogfood the changes.


  • You've updated the CHANGELOG
  • Middleware documentation is up to date
    • Please check out and modify the cider.nrepl ns which has all middleware documentation.
    • Run lein docs afterwards, and commit the results.

Sorry, something went wrong.

@alexander-yakushev alexander-yakushev force-pushed the haystack-to-orchard branch 2 times, most recently from 6a218d1 to a3ecb93 Compare March 11, 2025 18:05
Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. The test improvements are really nice!

I'm guessing no other editor is using directly analyze ops, as they are somewhat tied to how we've been doing things in CIDER, but we should probably check with Calva at least to make sure that's the case.

@alexander-yakushev
Copy link
Member Author

Searching through Calva source code shows that nothing uses analyze-stacktrace op.

@alexander-yakushev alexander-yakushev merged commit 16f0210 into master Mar 14, 2025
16 checks passed
@alexander-yakushev alexander-yakushev deleted the haystack-to-orchard branch March 14, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants