-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cider-find-keyword for clojure-ts-mode #3779
base: master
Are you sure you want to change the base?
Conversation
Looks like it's not that simple. CIDER currently doesn't have |
4c9e217
to
53c9ece
Compare
Not sure how to fix the linter error. Any suggestions are welcome. The |
7699e11
to
b86246c
Compare
I've figured it out :) |
90f0a9b
to
b6d834b
Compare
Let me think about this a bit, as I've got a small concern about leaking implementation details from the major modes in CIDER and I'm wondering what's the best way to abstract this away. Some work will definitely need to be done in this directly to fully embrace |
Sure, sounds good to me. We could probably define some helper in |
That's what I was thinking as well, otherwise I would have done it by now. Perhaps we can wrap all direct calls to |
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includes. There are warnings, but not because of my changes.checkdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
Currently
cider-find-keyword
doesn't work withclojure-ts-mode
, because it relies onclojure-keyword-face
text property (which is different for keywords forclojure-ts-mode
). I've introduced a small helper which uses text property forclojure-mode
and tree sitter based predicate forclojure-ts-mode
.