Remove unsupported backticks #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, one could include backticks in their node labels. However, Mermaid v10 introduced "Markdown formatting" (which despite its name is not Markdown, but just Markdown-style bold and italics) which uses the backticks as part of its delimiters. This broke these labels. I've changed the labels to no longer use the backticks. 🤷
movermeyer
changed the base branch from
master
to
movermeyer/python_313_support
movermeyer
force-pushed
the
movermeyer/diagram_fixup
branch
from
96fa4f3 to
46a28d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Sen on the Why ciso8601? page:
Previously, one could include backticks in their node labels. However, Mermaid v10.1.0 introduced "Markdown formatting" (which despite its name is not Markdown, but just Markdown-style bold and italics) which uses the backticks as part of its delimiters. This broke these labels.
Also the "no" edges were being rendered as "n".
What approach did you choose and why?
I've changed the labels to no longer use the backticks. 🤷
I quoted the
noedge labels, so they render correctly.What should reviewers focus on?
🤷. CI is failing due to unrelated issues (fixed in #158)
The impact of these changes
Node/edge labels will render correctly once again.
Testing
You can visit https://github.com/closeio/ciso8601/blob/movermeyer/diagram_fixup/why_ciso8601.md and see the rendered page with the fixes: