-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code clean up: rosa classic scripts #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
dags/openshift_nightlies/config/benchmarks/hcp-small-control-plane.json
Outdated
Show resolved
Hide resolved
dags/openshift_nightlies/config/benchmarks/hcp-small-control-plane.json
Outdated
Show resolved
Hide resolved
HCP light-weight c-d-v2 iteration will be 7 iteration/node
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 83.42% 79.06% -4.36%
==========================================
Files 21 22 +1
Lines 953 1003 +50
==========================================
- Hits 795 793 -2
- Misses 158 210 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dags/openshift_nightlies/config/benchmarks/hosted-control-plane-p75.json
Show resolved
Hide resolved
dags/openshift_nightlies/config/benchmarks/hosted-control-plane-p90.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* added rosahcp script * trimmed down extra char * updated workload HCP light-weight c-d-v2 iteration will be 7 iteration/node * removed extra env vars * increasing node ready timeout * mgmt cluster env var * scrapping metric for longer duration * updated query logic to index MC stat
Type of change
Description
Cleaned up rosa script and moved hosted-cp pieces to a different file.
Related Tickets & Documents
Checklist before requesting a review
Testing