Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code clean up: rosa classic scripts #345

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

mukrishn
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Cleaned up rosa script and moved hosted-cp pieces to a different file.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link
Member

@krishvoor krishvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mukrishn mukrishn requested a review from jtaleric July 27, 2023 12:34
HCP light-weight c-d-v2 iteration will be 7 iteration/node
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #345 (85d6fff) into master (81bf4cc) will decrease coverage by 4.36%.
Report is 1 commits behind head on master.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   83.42%   79.06%   -4.36%     
==========================================
  Files          21       22       +1     
  Lines         953     1003      +50     
==========================================
- Hits          795      793       -2     
- Misses        158      210      +52     
Flag Coverage Δ
gha 79.06% <97.72%> (-4.36%) ⬇️
python-3.9 79.06% <97.72%> (-4.36%) ⬇️
unit 79.06% <97.72%> (-4.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dags/openshift_nightlies/dag.py 73.16% <93.33%> (-9.07%) ⬇️
dags/openshift_nightlies/models/release.py 90.69% <100.00%> (ø)
dags/openshift_nightlies/tasks/benchmarks/e2e.py 84.26% <100.00%> (-1.28%) ⬇️
...ags/openshift_nightlies/tasks/install/rosa/rosa.py 100.00% <100.00%> (ø)
...enshift_nightlies/tasks/install/rosahcp/rosahcp.py 100.00% <100.00%> (ø)
dags/openshift_nightlies/util/manifest.py 73.93% <100.00%> (-5.54%) ⬇️
dags/openshift_nightlies/util/var_loader.py 93.93% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mukrishn mukrishn requested review from morenod and dry923 August 1, 2023 12:43
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dry923 dry923 merged commit 9ec4046 into cloud-bulldozer:master Aug 1, 2023
2 checks passed
@mukrishn mukrishn mentioned this pull request Aug 2, 2023
7 tasks
athiruma pushed a commit to athiruma/airflow-kubernetes that referenced this pull request Aug 7, 2023
* added rosahcp script

* trimmed down extra char

* updated workload
HCP light-weight c-d-v2 iteration will be 7 iteration/node

* removed extra env vars

* increasing node ready timeout

* mgmt cluster env var

* scrapping metric for longer duration

* updated query logic to index MC stat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants