Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws shared credential file #351

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

mukrishn
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #351 (63f57c0) into master (318650a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files          22       22           
  Lines        1003     1003           
=======================================
  Hits          793      793           
  Misses        210      210           
Flag Coverage Δ
gha 79.06% <ø> (ø)
python-3.9 79.06% <ø> (ø)
unit 79.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@venkataanil venkataanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukrishn
Copy link
Collaborator Author

Need cloud-bulldozer/scale-ci-deploy#216 to be merged first

@afcollins afcollins merged commit 745ea2c into cloud-bulldozer:master Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants