Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating SSH key-pair #53

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ygalblum
Copy link
Contributor

Type of change

  • New feature

Description

Add support for creating SSH key-pair.
Useful when running virtualization tests for checking boot completion on anything else on the guest VM

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • unit tests

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (20bf1a0) to head (6d0b66c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ssh/ssh.go 61.53% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   82.23%   80.15%   -2.09%     
==========================================
  Files           6        7       +1     
  Lines         349      388      +39     
==========================================
+ Hits          287      311      +24     
- Misses         48       58      +10     
- Partials       14       19       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ygalblum
Copy link
Contributor Author

I've fixed the lint issue. Not sure what to do with coverage. The lines that are not covered are for handling of errors from external libraries and I don't think it's worth defining interfaces for them

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit 0483bcc into cloud-bulldozer:main Feb 13, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants