Fix errors in grid coefficients for several azure regions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spazzy757
reviewed
Nov 21, 2023
| @@ -19,7 +19,7 @@ West India,Mumbai,,0.000708,carbonfootprint.com | |||
| UK South,London,,0.000228,EEA | |||
| UK West,Cardiff,,0.000228,EEA | |||
| France Central,Paris,,0.000067,EEA | |||
| Finland Central,Helsinki,,000077,EEA, | |||
| Germany West Central,Frankfurt,,000402,EEA | |||
| Finland Central,Helsinki,,0.000077,EEA, | |||
There was a problem hiding this comment.
This line maybe shouldnt have a comma at the end I beleive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes several error in the grid emissions factor of several azure regions. For several emission factors,
0.is missing at the beginning of the value. As I was the person who introduced these values in the original git repository, I can assure that the values are wrong and should be corrected this way.Sorry for having introduced these errors.
Best Regards,
Jonathan Pastor