If apply fails, attempt to run destroy #58
Conversation
|
|
|
/easycla |
baolsen
force-pushed
the
apply-destroy
branch
from
3487639 to
85c9323
Compare
baolsen
force-pushed
the
apply-destroy
branch
from
85c9323 to
a78f465
Compare
| @@ -12,7 +12,7 @@ classifiers=[ | |||
| readme = "README.md" | |||
|
|
|||
There was a problem hiding this comment.
Dependencies update is required for the current black hook to work.
| # Try to destroy partially applied resources | ||
| self.destroy() | ||
| finally: | ||
| raise e from None | ||
|
|
There was a problem hiding this comment.
Intentionally ignore any errors from Destroy. In the test case, Destroy happens to fail for the same reason as the apply fails. In production scenarios, Destroy will normally work and destroy anything partially created by the apply step.
| @@ -266,7 +273,8 @@ def parse_state( | |||
|
|
|||
| for r in data.get("resources", ()): | |||
There was a problem hiding this comment.
If resources are not correctly applied, the list of instances may be empty.
| local_file.foo | ||
| ] | ||
| } | ||
| """ |
There was a problem hiding this comment.
Simulate a partial apply:
1 TF apply creates some resources (the local file in this case)
2 TF apply fail on some unrelated resource
Unfortunately local_file resource wont fail if the local file exists already, it just overwrites. So I couldn't use it for the second step.
Instead, we force a failure using a data element to read a non existent file. The side effect of this is the destroy step also fails. But I couldn't find another way to simulate a scenario where a partial apply happens.
There was a problem hiding this comment.
|
@kapilt ready for review |
|
thanks for the pull request and detailed commentary. |
Codecov ReportBase: 92.81% // Head: 92.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 92.81% 92.90% +0.09%
==========================================
Files 8 8
Lines 473 479 +6
==========================================
+ Hits 439 445 +6
Misses 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@kapilt CI done |
closes #59