Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splits uaa-docker into its own section, beefs up readme #18

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

jduss4
Copy link
Contributor

@jduss4 jduss4 commented Feb 26, 2024

Changes proposed in this pull request:

  • sets up basic containerization needed to run a UAA server locally
  • provides documentation about the basic purpose of UAA

Originally the UAA docker directory was pushed along with the example cloud app. I have decoupled them for now, although the example app can certainly be configured to work with this UAA instance.

Things to check

  • does the documentation make sense? Is it missing anything that would help you understand what it is for?
  • are the steps "good enough" for us at this moment? For example, needing Zscaler to be disabled to set it up

Security considerations

  • because this is being run locally, the only security considerations would be to your own machine by disabling zscaler temporarily. This could be mitigated by incorporating the Zscaler certificate into the Docker images, something which I have not pursued in the interests of making progress instead of getting bogged down in details

@jduss4
Copy link
Contributor Author

jduss4 commented Feb 26, 2024

Note: the PRIVATE KEY in the uaa.yml file is coming from the example file that I found in cloud foundry's own repo: https://raw.githubusercontent.com/cloudfoundry/uaa/4.27.0/uaa/src/main/resources/required_configuration.yml

Copy link
Contributor

@echappen echappen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for setting this up. If we choose this path for more dev work, then I'd consider incorporating the Zscaler cert into the routine. But for now, this is a fine way to get the hang of UAA.

@jduss4 jduss4 merged commit 52b6f0f into main Feb 29, 2024
@jduss4 jduss4 deleted the jvd/uaa-docker branch February 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants