Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept nextjs adr #47

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Accept nextjs adr #47

merged 1 commit into from
Mar 18, 2024

Conversation

echappen
Copy link
Contributor

Changes proposed in this pull request:

  • Accepts ADR to use NextJS as our frontend framework

Security considerations

None - documentation only

@echappen echappen requested a review from hursey013 March 18, 2024 14:48
@echappen
Copy link
Contributor Author

I believe we said last Friday (15th) would be the last day of open commenting. I've heard no feedback on this ADR—have you? @hursey013 or @sknep (If there is more feedback, happy to extend)

@sknep sknep self-requested a review March 18, 2024 15:36
sknep
sknep approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sknep sknep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great. We've talked about this extensively. Brian is out today, so you can wait for him or accept my approval as proxy :)

@echappen echappen merged commit 38036b8 into main Mar 18, 2024
1 check passed
@echappen echappen deleted the eoc/accept-next-adr branch March 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sknep sknep sknep approved these changes

@hursey013 hursey013 Awaiting requested review from hursey013

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echappen @sknep