chore: add zap scan #4569
Closed
chore: add zap scan #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
force-pushed
the
chore-add-zap-scan
branch
5 times, most recently
from
ba04674
to
956b3cc
Compare
drewbo
force-pushed
the
chore-add-zap-scan
branch
2 times, most recently
from
83e0f72
to
7a73239
Compare
drewbo
force-pushed
the
chore-add-zap-scan
branch
from
7a73239
to
89d735b
Compare
apburnes
reviewed
Aug 21, 2024
scripts/create-test-users.js
Outdated
| @@ -4,7 +4,7 @@ const factory = require('../test/api/support/factory'); | |||
| const { authenticatedSession } = require('../e2e/auth-session'); | |||
|
|
|||
| async function createUsers() { | |||
| const user = await factory.user({ username: 'test-e2e-user' }); | |||
| const user = await factory.user({ username: process.env.PAGES_TEST_USER || 'generic-test-user' }); | |||
There was a problem hiding this comment.
Do we want to update this user to belong to an org? Manage an org?
There was a problem hiding this comment.
we don't really have standardized fixture data for them to test against but having them in an org could be okay
|
Issues running this on admin/queues SPAs, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
This adds an admin test user to the database to scan sites, it is removed after scanning.