Consolidate login.gov url
#218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdembe
force-pushed
the
login-redirect-revisit
branch
from
eebaf9e
to
cde64e0
Compare
aduth
reviewed
Aug 10, 2023
pages.yml
Outdated
Comment on lines
52
to
53
| - from: www.login.gov | ||
| to: login.gov |
There was a problem hiding this comment.
We want the reverse, to redirect from login.gov to www.login.gov
Or at least we've been using www version as canonical in the site itself and in links generating on the IdP.
aduth
reviewed
Sep 29, 2023
| @@ -496,6 +496,14 @@ server { | |||
| return 301 https://$target_domain; | |||
| } | |||
|
|
|||
| # www.login.gov to login.gov | |||
There was a problem hiding this comment.
Suggested change
| # www.login.gov to login.gov | |
| # login.gov to www.login.gov |
| @@ -30,6 +30,7 @@ const expectedRedirects = [ | |||
| { from: 'usability.gov', to: 'www.usability.gov', redirectCode: 301 }, | |||
| { from: 'emerging.digital.gov', to: 'digital.gov/topics/emerging-tech', redirectCode: 301, noPath: true }, | |||
| { from: 'components.designsystem.digital.gov', to: 'designsystem.digital.gov/components', redirectCode: 301, noPath: true }, | |||
| { from: 'www.login.gov', to: 'login.gov', redirectCode: 301} | |||
There was a problem hiding this comment.
Looks like a syntax error with missing comma
Suggested change
| { from: 'www.login.gov', to: 'login.gov', redirectCode: 301} | |
| { from: 'www.login.gov', to: 'login.gov', redirectCode: 301 }, |
Comment on lines
+52
to
+54
| - from: login.gov | ||
| to: www.login.gov | ||
| toDomain: login.gov |
There was a problem hiding this comment.
Is this needed? Stands out to me that toDomain is the legacy domain. Should it be the new domain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Current state: login.gov and www.login.gov are two valid and separate URLs that look like they are the same website. This PR will work to consolidate the URLs--a user will hit login.gov no matter what URL that they use.
C
Security considerations
None