Fixes issue with files name containing colon :
#4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file path passed is an absolute file path and if its name contains colon
:
then the URI parsed will be wrong as the scheme parsed will be not unusable.More detail:-
Example path with issue:
/data/user/0/com.example.appname/cache/2022-11-05 20:53:17.783069.png
.Now, for the example the
parsedScheme
ingetURI
will be/data/user/0/com.example.appname/cache/2022-11-05 20
as a scheme is anything before colon. Due to thisgetURI
will return us the same string passed which will be unusable further down the code.So, what we do is check if the string passed to
getURI
starts with/
or not, if it starts with/
then most probably it is an absolute file path.Let me know if you have any questions about this change.