Make sure name of Queues, Exchanges and Vhosts is not longer than 255 characters #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do this more 'centralized' instead? Like either in a validator that checks length of all fields with |
viktorerlingsson
force-pushed
the
maxlength_255_names
branch
from
76136a2
to
26f8dd9
Compare
carlhoerberg
requested changes
Feb 11, 2024
carlhoerberg
approved these changes
Feb 12, 2024
Co-authored-by: Carl Hörberg <[email protected]>
viktorerlingsson
force-pushed
the
maxlength_255_names
branch
from
dc45def
to
71b3ce6
Compare
viktorerlingsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Stops users from creating queues, vhosts and exchanges with names longer than 255 characters (short string)
HOW can this pull request be tested?
Specs? Manual steps? Please fill me in.