HTTP API docs: improve get message request body documentation #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have supported "ackmode" since v1.0.0-beta.1.
These seem to be the values supported by LavinMQ: https://github.com/cloudamqp/lavinmq/blob/v1.2.10/src/lavinmq/http/controller/queues.cr#L159-L162
|
|
kickster97
approved these changes
Apr 4, 2024
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
* HTTP API docs: document `ackmode` over `ack_mode` We have supported "ackmode" since v1.0.0-beta.1. * HTTP API docs: document options for `ackmode` These seem to be the values supported by LavinMQ: https://github.com/cloudamqp/lavinmq/blob/v1.2.10/src/lavinmq/http/controller/queues.cr#L159-L162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document
ackmodeoverack_modeWe have supported "ackmode" since v1.0.0-beta.1 ("Get messages" fixes: ackmode and redelivery flag #347)
document options for
ackmodeThese seem to be the values supported by LavinMQ: https://github.com/cloudamqp/lavinmq/blob/v1.2.10/src/lavinmq/http/controller/queues.cr#L159-L162