Allow array of URIs when creating shovel #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
requested review from
carlhoerberg,
snichme,
spuun and
viktorerlingsson
as code owners
kickster97
changed the title
spuun
approved these changes
Jun 10, 2024
| @@ -8,6 +8,13 @@ module LavinMQ | |||
|
|
|||
| forward_missing_to @shovels | |||
|
|
|||
| def parse_uris(src_uri) : Array(URI) | |||
| uris = src_uri.as_s? ? [src_uri.as_s] : src_uri.as_a.map(&.as_s) | |||
There was a problem hiding this comment.
This could probably be
Suggested change
| uris = src_uri.as_s? ? [src_uri.as_s] : src_uri.as_a.map(&.as_s) | |
| uris = src_uri.as_s? || src_uri.as_a.map(&.as_s) |
There was a problem hiding this comment.
does not work for map,
undefined method 'map' for String (compile-time type is (Array(String) | String))
snichme
approved these changes
Jun 12, 2024
kickster97
force-pushed
the
allow_mulitple_uri_shovel
branch
from
23f0527
to
486c9cc
Compare
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
* add destinationWrapper and allow multiple uris for creating shovel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Allows for multiple URIs to be sent in when creating a shovel. This input can now be either a string, or an array of strings. If more than one uri string is provided, the shovel will randomly pick one URI from the list until one of the endpoints succeeds.
Needed for compatibility with clients
still needs some small adjustments
HOW can this pull request be tested?
Try to create a shovel and send in multiple uris