Add tags and description to vhost #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
requested review from
carlhoerberg,
snichme,
spuun and
viktorerlingsson
as code owners
kickster97
changed the title
snichme
approved these changes
May 31, 2024
spuun
reviewed
Jun 4, 2024
There was a problem hiding this comment.
When retrieving a vhost via http api in rabbitmq the root object contains (among others) description (string), tags (array) and metadata (object). The metadata object contains description (string) and tags (array).
Dunno why it has that metadata object and values in the root object.
Anyway, based on this I'd say we should store tags as an array.
kickster97
force-pushed
the
add-tags-and-description
branch
from
7380968
to
c39bd1a
Compare
spuun
reviewed
Jun 14, 2024
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
Co-authored-by: Carl Hörberg <[email protected]>
carlhoerberg
approved these changes
Jun 18, 2024
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
* add tags and description to vhost --------- Co-authored-by: Carl Hörberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
add tags and description to vhost, and add them to details tuple.
needed for client compatibility
discuss: do we want this?
HOW can this pull request be tested?
GET /vhostsresponse should have description and tags