escape symbols in names for lavinmqctl #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
requested review from
carlhoerberg,
snichme,
spuun and
viktorerlingsson
as code owners
carlhoerberg
approved these changes
Jun 8, 2024
snichme
approved these changes
Jun 10, 2024
spuun
approved these changes
Jun 14, 2024
viktorerlingsson
pushed a commit
that referenced
this pull request
Sep 20, 2024
use URI.encode_www_form to escape symbols in vhost or queue names for laivnmqctl. Before this if you want to create a vhost named "rabbit/hole", lavinmqctl crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
uses
URI.encode_www_formto escape symbols in vhost or queue names for laivnmqctl.currently if you want to create a vhost names rabbit/hole, lavinmqctl crashes.
HOW can this pull request be tested?
try to use lavinmqctl to create vhost "a/b"
then rebuild lavinmqctl with these changes and try again