Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only consider MIN_ISR requirements if listeners are started #735

Closed
wants to merge 4 commits into from
Closed

only consider MIN_ISR requirements if listeners are started #735

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5523154
only consider MIN_ISR requirements if listeners are started
viktorerlingsson Jul 22, 2024
5c79cf9
return early if no listeners
viktorerlingsson Jul 23, 2024
2cecd7e
remove extra end
viktorerlingsson Jul 23, 2024
69ed81b
format
viktorerlingsson Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lavinmq/clustering/server.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ module LavinMQ

private def each_follower(& : Follower -> Nil) : Nil
isr_count = @followers.size
return if @listeners.empty? # Don't require ISRs before the server has started and followers can connect

until isr_count >= @config.clustering_min_isr
Log.warn { "ISR requirement not met (#{isr_count}/#{@config.clustering_min_isr})" }
isr_count = @has_followers.receive? || return
Expand Down
Loading