Fix flaky shovel spec and potential bug in source ack #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
kickster97
approved these changes
Aug 19, 2024
snichme
approved these changes
Aug 20, 2024
carlhoerberg
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
The
should ack all messages that has been movedspec was very flaky. When debugging it I found what I think was a bug, thatSource#ackwouldn't ack on stop depending on the values ofdelivery_tagandprefetch. Because we batch acks, thedelivery_taghad to be a multiple of half theprefetchfor the ack to happen. Now#ackhas a optional parameter to not batch.The spec succeeded (but not always because flaky?) because it used
prefetch1. It's refactored to make sure that there should be unacked messages when the shovel is terminated.HOW can this pull request be tested?
Run specs