Bugfix: shovel sources reconnect #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version got the exception from `start`, not `each`
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
carlhoerberg
approved these changes
Aug 24, 2024
snichme
approved these changes
Aug 26, 2024
spuun
added a commit
that referenced
this pull request
Aug 27, 2024
spuun
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
It turned out that #754 didn't fix the problem. The spec that was supposed to verify the bugfix was wrong.
This PR will
HOW can this pull request be tested?
Run specs