Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavinmqctl - add comment that node option is only used for tests #771

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

viktorerlingsson
Copy link
Member

@viktorerlingsson viktorerlingsson commented Aug 27, 2024

WHAT is this pull request doing?

Adds a comment about the node option inlavinmqctl that it's only used for tests

@kickster97 kickster97 self-requested a review August 27, 2024 12:40
@viktorerlingsson
Copy link
Member Author

Needed by RabbitMQ java client tests.

@walro
Copy link

walro commented Aug 27, 2024

Needed by RabbitMQ java client tests.

Add as a comment so we don't try to remove it again in 3 years 😄

@viktorerlingsson viktorerlingsson changed the title lavinmqctl - remove unused node option lavinmqctl - add comment that node option is only used for tests Aug 27, 2024
@viktorerlingsson
Copy link
Member Author

Needed by RabbitMQ java client tests.

Add as a comment so we don't try to remove it again in 3 years 😄

Smart! 🧠

@viktorerlingsson viktorerlingsson merged commit 62b6e24 into main Aug 27, 2024
24 of 25 checks passed
@viktorerlingsson viktorerlingsson deleted the lavinmqctl-remove-unused-node-option branch August 27, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants