Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .deb build workflow #772

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix .deb build workflow #772

merged 1 commit into from
Aug 29, 2024

Conversation

spuun
Copy link
Member

@spuun spuun commented Aug 28, 2024

WHAT is this pull request doing?

When preparing to build the deb packet we explicit COPY extras/lavinmq.service debian/. Then when debuild runs it will exec make install which will copy lavinmq.service to debian/lavinmq/lib/systemd/system/lavinmq.service.
For some reason this results in an error when trying to install to deb packet in ubuntu 24.04:

dpkg: error processing archive /var/cache/apt/archives/lavinmq_2.0.0-rc.3-1_amd64.deb (--unpack):
 unable to open '/usr/lib/systemd/system/lavinmq.service.dpkg-new': No such file or directory
No apport report written because the error message indicates an issue on the local system

HOW can this pull request be tested?

Check GH actions?

walro
walro approved these changes Aug 28, 2024
View reviewed changes
Copy link

@walro walro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs fine on 24.04 at least, haven't tested 22.04.

@spuun
Copy link
Member Author

spuun commented Aug 29, 2024

22.04 works

@spuun spuun merged commit 5b83086 into main Aug 29, 2024
6 checks passed
@spuun spuun deleted the fix-deb-builds branch August 29, 2024 06:29
spuun added a commit that referenced this pull request Aug 29, 2024
@spuun
Fix .deb build workflow (install failed on 24.04) (#772)
3975278
@spuun spuun mentioned this pull request Aug 29, 2024
Merged
spuun added a commit that referenced this pull request Aug 29, 2024
@spuun
Fix .deb build workflow (install failed on 24.04) (backport #772) (#773)
268b98a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walro walro walro approved these changes

@carlhoerberg carlhoerberg Awaiting requested review from carlhoerberg

@kickster97 kickster97 Awaiting requested review from kickster97

@snichme snichme Awaiting requested review from snichme

@viktorerlingsson viktorerlingsson Awaiting requested review from viktorerlingsson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spuun @walro