Clustering - Write to tempfile first when getting full file #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
reviewed
Oct 22, 2024
viktorerlingsson
force-pushed
the
clustering-write-to-tempfile
branch
from
c909170
to
e6abe2b
Compare
carlhoerberg
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Writes full file to a tempfile first and then renames it to replace the old file when getting full file on followers. This ensures that followers always has a complete file ready.
The
Clustering::AddActionis only ever used byreplace_fileas far as I can tell, meaning we shouldn't have to look for existing files.Fixes #806
HOW can this pull request be tested?
Run spec.