use the correct data-sort-key for unacknowledged messages #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanrhodin
reviewed
Nov 8, 2024
we don't have unacknowledged messages as a column in the consumers view, or is it another column in consumers you mean? |
|
Sorry I mean the prefetch count is not correctly sorted in the consumers view |
ah ok, interesting.. this is all really messy! fixed that one aswell now. |
carlhoerberg
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
updates the data-sort-key for unacknowledged messages in the channels, and connections ecr files.
Fixes: #820
HOW can this pull request be tested?
make clean-viewsmake viewsnow look at the channels tab, and sort on unacknowledged messages.