Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 246 auth backend #862

Draft
wants to merge 39 commits into
base: oauth2-support
Choose a base branch
from

Conversation

JadeKharats
Copy link

WHAT is this pull request doing?

Allows ConnectionFactory to use a chain of responsibility to authenticate users via multiple configured providers. A cache management is implemented to avoid calls that are too slow in http

WIP :
Initialize auth_chain with config.
Find a solution so that external auth services return LavinMQ::User

HOW can this pull request be tested?

Added fake auth_http_backend server in helper.
Cache and auth_chain have dedicated tests

JadeKharats and others added 30 commits November 8, 2024 21:02
Increases default lease TTL 5s -> 10s. Also timeouts earlier so lease_keepalive has a longer window to run (3s instead of 0.5s), which should make it less likely that unnecessary leader elections happen.
Adds followers section to api docs.
Exit with status 1 if lost leadership without previous graceful shutdown, so that systemd with "restart on failure" restarts it.
Yields during MessageStore#delete so that LavinMQ does not freeze while deleting large queues.
…deleted_definitions (cloudamqp#858)

Speeds up the should_compact_definitions_during_runtime spec by setting max_deleted_definitions=8 instead of the default 8192.
Copy link

github-actions bot commented Nov 26, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


2 out of 5 committers have signed the CLA.
✅ (JadeKharats)[https://github.com/JadeKharats]
✅ (spuun)[https://github.com/spuun]
@viktorerlingsson
@carlhoerberg
@kickster97
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@JadeKharats
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

lavinmq-user-84 added a commit to cloudamqp/CLA-signatures that referenced this pull request Nov 26, 2024
@kickster97
Copy link
Member

kickster97 commented Nov 27, 2024

Awesome!
I need access/rights to the fork repository in order to cherry pick code into the Oauth2 branch

JadeKharats and others added 6 commits November 27, 2024 23:40
If a msg file is a few bytes larger than expected, first? will throw an IndexError and close the queue. This changes that behavior to instead rescue that IndexError and try to move on to the next segment file. Same fix as for shift? in cloudamqp#671

fixes cloudamqp#669 (again 🙂)
Don't redeclare exchange in test/java/com/rabbitmq/client/test/functional/Tables.java.
* rescue and close queue if LavinMQ starts with faulty msg_store

---------

Co-authored-by: Jon Börjesson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants