LITE-28568 task for price list uploading #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzevaka
force-pushed
the
feature/LITE-28568_apply-prices
branch
3 times, most recently
from
3891630
to
ccc9d0e
Compare
zzzevaka
changed the title
zzzevaka
force-pushed
the
feature/LITE-28568_apply-prices
branch
from
ccc9d0e
to
30e0d55
Compare
zzzevaka
force-pushed
the
feature/LITE-28568_apply-prices
branch
from
30e0d55
to
d900534
Compare
akodelia
reviewed
Sep 26, 2023
| @@ -220,7 +220,7 @@ def get_cbc_extension_db(engine: Engine = Depends(get_cbc_extension_db_engine)): | |||
| ) | |||
| db: Session = SessionMaker(bind=engine) | |||
| try: | |||
| yield db | |||
| return db | |||
There was a problem hiding this comment.
[COD-C] why do we need this change?
There was a problem hiding this comment.
Before it was used as a FastAPI Depends
Now it is used only as a normal function and it doesn't work
akodelia
approved these changes
Sep 27, 2023
Hairash
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.