Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tasks logging. Send pricelist to media #119

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Improve tasks logging. Send pricelist to media #119

merged 3 commits into from
Oct 13, 2023

Conversation

zzzevaka
Copy link
Contributor

@zzzevaka zzzevaka commented Oct 3, 2023

No description provided.

@zzzevaka zzzevaka force-pushed the task-manager-debug branch 4 times, most recently from d14c906 to 02f3386 Compare October 6, 2023 10:47
@zzzevaka zzzevaka changed the title [DRAFT] Stacktrace added to error messages in task manager Improve tasks logging. Send pricelist to media Oct 6, 2023
Hairash
Hairash approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Hairash Hairash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to make one commit instead of 3 following the agreement we have for the PRs if you don't mind

connect_ext_ppr/services/pricing.py Outdated Show resolved Hide resolved
@zzzevaka
Copy link
Contributor Author

zzzevaka commented Oct 13, 2023 •
edited
Loading

I propose to make one commit instead of 3 following the agreement we have for the PRs if you don't mind

Could you refer to which agreement you mean?

There are 3 changes that are not related to each other. I would prefer to leave it as is.

@zzzevaka zzzevaka merged commit da86e3a into master Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hairash Hairash Hairash approved these changes

@akodelia akodelia Awaiting requested review from akodelia

@maxipavlovic maxipavlovic Awaiting requested review from maxipavlovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzzevaka @Hairash