LITE-28012 Add upload files functionality #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hairash
approved these changes
Jul 11, 2023
Hairash
reviewed
Jul 11, 2023
| assert proxied == { | ||
| '/public/v1/media': 'edit', | ||
| } | ||
|
|
There was a problem hiding this comment.
I also propose to add one more test to check the resulting url, because theoretically proxied_connect_api may change in future.
It's not crucial to implement it now, but I think it's good to add it one day. Do you agree?
There was a problem hiding this comment.
The test here is to keep track of proxied endpoints that webapp currently have. Im not sure if full url could be tested from the api_client, because proxied_connect_api is a configuration for the runner.
akodelia
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.