Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LITE-29057 Output product version for Deployment Request #139

Merged
merged 1 commit into from
Feb 13, 2024
Merged

LITE-29057 Output product version for Deployment Request #139

merged 1 commit into from
Feb 13, 2024

Conversation

Hairash
Copy link
Contributor

@Hairash Hairash commented Jan 15, 2024

No description provided.

Hairash
Hairash commented Jan 15, 2024
View reviewed changes
connect_ext_ppr/utils.py
:param deployment: Deployment model
:param product: Product model from Connect
:param vendor: Vendor Account model from Connect
Returns DeploymentRequestSchema for the deployment request
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed the wrong description passing by

arnaugiralt
arnaugiralt requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@arnaugiralt arnaugiralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to commit the static files for the frontend, inside the connect_ext_ppr/static directory.

@Hairash Hairash force-pushed the LITE-29057-show-product-version-in-dr branch from 101214e to 18ede43 Compare January 15, 2024 16:43
@Hairash Hairash force-pushed the LITE-29057-show-product-version-in-dr branch from 18ede43 to c946672 Compare February 13, 2024 09:21
@Hairash Hairash merged commit c6f23eb into master Feb 13, 2024
8 checks passed
@Hairash Hairash deleted the LITE-29057-show-product-version-in-dr branch February 13, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akodelia akodelia akodelia approved these changes

@arnaugiralt arnaugiralt arnaugiralt approved these changes

@jonatrios jonatrios jonatrios approved these changes

@nerimartinez nerimartinez Awaiting requested review from nerimartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hairash @akodelia @arnaugiralt @jonatrios