LITE-27893 Add validation step for PPR upload #19
Conversation
jonatrios
force-pushed
the
LITE-27893-add-validation-step-on-ppr-creation
branch
3 times, most recently
from
1a54a8c
to
8ba3f9c
Compare
|
One general question - why are we not using CBC API for validation?
|
| "enum": [ | ||
| "OldName_1", | ||
| "Name_EN", | ||
| "Description_EN", |
There was a problem hiding this comment.
Name and description both can be multilingual.
There was a problem hiding this comment.
That's great, but only EN is required only
There was a problem hiding this comment.
Ok, will allow additional fields for "ServicePlans" that starts with "Name_" / "Description_"
There was a problem hiding this comment.
I'll merge the PR, but please check that if any additional column appears we shouldn't fail because of it. The system should be treated as open - which means it retrieves all needed information from the input and ignore others
|
@rahulmondal Nope, on uploading the PPR we don't have the hub to validate against, the only thing that we can do here to check required sheets and fields inside |
jonatrios
changed the title
jonatrios
force-pushed
the
LITE-27893-add-validation-step-on-ppr-creation
branch
from
8ba3f9c
to
a63e072
Compare
| try: | ||
| jsonschema.validate(dict_file, PPR_SCHEMA) | ||
| except jsonschema.ValidationError as ex: | ||
| error = ClientError( |
There was a problem hiding this comment.
[SOL-C] Propose to make an error class to store all the errors in one place.
Otherwise we may get confused in the error codes. Do you agree?
| "enum": [ | ||
| "OldName_1", | ||
| "Name_EN", | ||
| "Description_EN", |
There was a problem hiding this comment.
That's great, but only EN is required only
| "enum": [ | ||
| "OldName_1", | ||
| "Name_EN", | ||
| "Description_EN", |
There was a problem hiding this comment.
I'll merge the PR, but please check that if any additional column appears we shouldn't fail because of it. The system should be treated as open - which means it retrieves all needed information from the input and ignore others
@d3rky |
No description provided.