LITE-28161 Add user id and name to Configuration events #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hairash
commented
Jul 24, 2023
| @@ -61,7 +62,7 @@ class ConnectExtensionXvsWebApplication(WebApplicationBase): | |||
|
|
|||
| @router.get( | |||
| '/deployments/requests', | |||
| summary='List all request accross deployments', | |||
| summary='List all requests across deployments', | |||
Hairash
commented
Jul 24, 2023
| @@ -238,7 +240,7 @@ def add_configuration( | |||
| mime_type=file_data.mime_type, | |||
| ) | |||
| db.add(file_instance) | |||
| db.commit() | |||
| db.flush() | |||
There was a problem hiding this comment.
Needed for transaction because db.commit() ends transaction
Hairash
force-pushed
the
LITE-28161-add-user-info
branch
from
5bfb3f4
to
47d0cfc
Compare
Hairash
force-pushed
the
LITE-28161-add-user-info
branch
from
47d0cfc
to
acf77f7
Compare
d3rky
approved these changes
Jul 24, 2023
| @@ -108,6 +108,12 @@ def test_post_configuration( | |||
| 'mime_type': media_response['mime_type'], | |||
| }, | |||
| }, | |||
| headers={ | |||
| "connect-auth": ( | |||
There was a problem hiding this comment.
For tests it is better to generate the test signature based on human-readable input. Otherwise hard to understand what is inside and what should be expected in the tests
| updated_at = db.Column(db.DateTime(), default=datetime.utcnow) | ||
| updated_by = db.Column(db.String(20)) | ||
| updated_by = db.Column(db.JSON) |
There was a problem hiding this comment.
Honestly speaking, I don't like the idea of storing it as JSON here, cause of:
- What id the name of the user changed?
- Filtering, rql or other filters doesn't support JSON fields filters for now
Let's have it as is for now, but I'll put it as the gap
| @@ -72,7 +72,7 @@ class ConfigurationSchema(NonNullSchema): | |||
| id: str | |||
| file: FileSchema | |||
| state: ConfigurationStateChoices | |||
| events: Dict[str, Dict[str, Union[datetime, str]]] | |||
| events: Dict[str, Dict[str, Union[datetime, Dict[str, str]]]] | |||
There was a problem hiding this comment.
For the future --> TypeAliases will help you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.