LITE-28177: Listing products that an account have at least one deployment #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3rky
suggested changes
Jul 24, 2023
connect_ext_ppr/webapp.py
Outdated
| installation: dict = Depends(get_installation), | ||
| ): | ||
| products_ids = db.query(Deployment.product_id).options( | ||
| joinedload(Deployment.product), |
There was a problem hiding this comment.
What is the reason to have a separate query for the products here? I mean, Postgresql supports fields in distinct + you already joined all the data and can just go through it. Is it possible to do?
akodelia
force-pushed
the
feature/LITE-28177-get-products
branch
from
22d84c0
to
f550ad8
Compare
akodelia
force-pushed
the
feature/LITE-28177-get-products
branch
from
f550ad8
to
54be559
Compare
d3rky
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.